feat(ui): inline edit #35
Draft
+287
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuyuanp
force-pushed
the
feat/support-inline-edit-display
branch
from
be0415b to
9cdb7af
Compare
tris203
force-pushed
the
minimal_edits
branch
2 times, most recently
from
3486215 to
92af03e
Compare
Introduce new support for LCS-based diff generation and minimal text edits. • Add lcs.lua to compute diffs based on longest common subsequence. • Add mimimal_edits.lua to reduce and optimize text edits. • Update nes/init.lua to apply minimal edits when a single edit is returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new support for LCS-based diff generation and minimal text edits.
• Add lcs.lua to compute diffs based on longest common subsequence.
• Add mimimal_edits.lua to reduce and optimize text edits.
• Update nes/init.lua to apply minimal edits when a single edit is returned.
Following on from #34, this allow for edits to be reduced. although I'm not sure its always appropriate, this might be best paired with something like #3 as this makes where the changes are taking place much more subtle
NOTE: This isn't intended to be merged, but more as a discussion point of what we could do